nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on issue #185: nsh improvement
Date Sun, 19 Apr 2020 14:30:18 GMT
patacongo commented on issue #185: nsh improvement
URL: https://github.com/apache/incubator-nuttx-apps/pull/185#issuecomment-616148130
 
 
   > I found that we forget to call boardctl(BOARDIOC_FINALINIT) when CONFIG_NSH_TELNET
equals y and CONFIG_NSH_CONSOLE equals n. Calling boardctl(BOARDIOC_FINALINIT) inside nsh_initscript
can fix this problem and avoid the code duplication.
   
   But isn't nsh_initscript only called if there is an initialization script?  Does that mean
that the function calls moved tin nsh_initscript() will not be executed if there is no initialization
script (the default case).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message