nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #185: nsh improvement
Date Sun, 19 Apr 2020 14:14:10 GMT
xiaoxiang781216 commented on issue #185: nsh improvement
URL: https://github.com/apache/incubator-nuttx-apps/pull/185#issuecomment-616144601
 
 
   > The change is more complex than I expected and appears to include additional, unexplained
changes. For example, why is boardctl(BOARDIOC_FINALINIT) removed?
   
   I found that we forget to call  boardctl(BOARDIOC_FINALINIT) when CONFIG_NSH_TELNET equals
y and CONFIG_NSH_CONSOLE equals n. Calling boardctl(BOARDIOC_FINALINIT) inside nsh_initscript
can fix this problem and avoid the code duplication.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message