nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #185: nsh improvement
Date Sat, 18 Apr 2020 10:33:47 GMT
xiaoxiang781216 commented on a change in pull request #185: nsh improvement
URL: https://github.com/apache/incubator-nuttx-apps/pull/185#discussion_r410680271
 
 

 ##########
 File path: system/system/system.c
 ##########
 @@ -148,7 +148,7 @@ int system(FAR const char *cmd)
   errcode = posix_spawn(&pid, CONFIG_SYSTEM_SYSTEM_SHPATH,  NULL, &attr,
                         argv, (FAR char * const *)NULL);
 #else
-  errcode = task_spawn(&pid, "popen", nsh_system, NULL, &attr,
+  errcode = task_spawn(&pid, "system", nsh_system, NULL, &attr,
 
 Review comment:
   This argument give the new task a name:
   1.system function should get the name "system"
   2.popen function should get the name "popen"
   I think this is a typo error and then make a change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message