nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #185: nsh improvement
Date Fri, 17 Apr 2020 22:48:32 GMT
patacongo commented on a change in pull request #185: nsh improvement
URL: https://github.com/apache/incubator-nuttx-apps/pull/185#discussion_r410501604
 
 

 ##########
 File path: nshlib/nsh.h
 ##########
 @@ -1008,10 +1008,15 @@ int cmd_irqinfo(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv);
   int cmd_readlink(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv);
 #endif
 #if CONFIG_NFILE_STREAMS > 0 && !defined(CONFIG_NSH_DISABLESCRIPT)
-#  ifndef CONFIG_NSH_DISABLE_SH
+#if !defined(CONFIG_NSH_DISABLE_SH) && defined(CONFIG_SYSTEM_SYSTEM)
 
 Review comment:
   You would also have to have SYSTEM command enabled.
   
   NOTE:  This effects only the SH command.  The start-up script goes through a different
path:  nsh_main->nsh_consolemain->nsh_initscript->nsh_script
   
   So the the init script always executes on the thread of execution of nsh_main().
   
   I believe that this change is consistent with the POSIX requirement and it must be included.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message