nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #183: nshlib/nsh_codeccmd.c: fix potential NULL dereference and check mallo…
Date Thu, 16 Apr 2020 18:53:32 GMT
patacongo commented on a change in pull request #183: nshlib/nsh_codeccmd.c: fix potential
NULL dereference and check mallo…
URL: https://github.com/apache/incubator-nuttx-apps/pull/183#discussion_r409778427
 
 

 ##########
 File path: include/netutils/md5.h
 ##########
 @@ -74,24 +73,24 @@ extern "C"
  * Public Types
  ****************************************************************************/
 
-struct MD5Context
+struct md5_context_s
 {
   uint32_t buf[4];
   uint32_t bits[2];
   uint8_t in[64];
 };
 
-typedef struct MD5Context MD5_CTX;
+typedef struct md5_context_s MD5_CTX;
 
 Review comment:
   Hmm... there are other examples where upper case types are used for handles (after Microsoft
conventions).  I suppose we should end that practice because it is non-compliant with the
standard.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message