nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
Date Tue, 14 Apr 2020 23:30:48 GMT
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit
support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408494579
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_gpio.c
 ##########
 @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset)
       return -EINVAL;
     }
 
+#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF))
 
 Review comment:
   I made this change in commit 7d70abc4d4a1. Because g_gpiobase[5] and g_gpiobase[6] is initted
to 0, a null check is now required in stm32_gpioread() and stm32_gpiowrite(). I added those
and fixed resulting nxstyle complaints.
   
   Waiting to hear your thoughts... Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message