nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
Date Tue, 14 Apr 2020 22:37:32 GMT
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support
for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408475913
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_gpio.c
 ##########
 @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset)
       return -EINVAL;
     }
 
+#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF))
 
 Review comment:
   Can all this be just a null check on line 181?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message