nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
Date Tue, 14 Apr 2020 22:37:32 GMT
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support
for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408474857
 
 

 ##########
 File path: arch/arm/src/stm32h7/Kconfig
 ##########
 @@ -289,13 +468,13 @@ config STM32H7_ETHMAC
 	select ARCH_HAVE_PHY
 
 config STM32H7_FMC
-        bool "FMC"
-        default n
-        depends on STM32H7_HAVE_FMC
-        ---help---
-                Enable Flexible Memory Controller.
-                To correctly configure FMC for your hardware, you will have to define
-                a number of macros in your board.h file. See stm32_fmc.c for directions.
+		bool "FMC"
 
 Review comment:
   This block looks to be indented wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message