nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning
Date Mon, 13 Apr 2020 15:58:36 GMT
patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning
URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407554097
 
 

 ##########
 File path: arch/mips/src/pic32mx/pic32mx-usbdev.c
 ##########
 @@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv)
   /* At this point, the request has been handled and there are three possible
    * outcomes:
    *
-   * 1. The setup request was successfully handled above and a response packet
-   *    must be sent (may be a zero length packet).
+   * 1. The setup request was successfully handled above and a response
+   *    packet must be sent (may be a zero length packet).
    * 2. The request was successfully handled by the class implementation.  In
-   *    case, the EP0 IN response has already been queued and the local variable
-   *    'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL;
-   * 3. An error was detected in either the above logic or by the class implementation
-   *    logic.  In either case, priv->state will be set CTRLSTATE_STALL
-   *    to indicate this case.
+   *    variable case, the EP0 IN response has already been queued and the
+   *    local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL
 
 Review comment:
   The word 'this' is missing beween "In case"
   
   The word variable belongs on line 2412 after local
   
   The single quotes around 'dispatched' are really necessary to make the sense readable.
 Otherwise, it looks like a word in the sentence, not a variable name.  ctrlstate does not
have this confusion.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message