nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] yamt commented on a change in pull request #775: modlib: #if 0 out unused modlib_sectname
Date Mon, 13 Apr 2020 06:16:17 GMT
yamt commented on a change in pull request #775: modlib: #if 0 out unused modlib_sectname
URL: https://github.com/apache/incubator-nuttx/pull/775#discussion_r407335947
 
 

 ##########
 File path: libs/libc/modlib/modlib_sections.c
 ##########
 @@ -66,6 +66,7 @@
  *
  ****************************************************************************/
 
+#if 0 /* Not used */
 
 Review comment:
   i just followed the existing convention. i'm fine with either ways.
   iirc, the linker optimization traditionally works at object level, not functions, though.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message