nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] hartmannathan commented on issue #765: sched/sched_setpriority.c: DEBUGVERIFY, not DEBUGASSERT.
Date Sun, 12 Apr 2020 19:11:52 GMT
hartmannathan commented on issue #765: sched/sched_setpriority.c:  DEBUGVERIFY, not DEBUGASSERT.
URL: https://github.com/apache/incubator-nuttx/pull/765#issuecomment-612662513
 
 
   I did some searching to see if there might be other instances of the same problem.
   
   There are thousands and thousands of DEBUGASSERT statements so it's a little challenging
to wade through all of them, but I found four that I suspect might be wrong:
   
   **(1) In function arm_boot(), line 343, arch/arm/src/tms570/tms570_boot.c:**
   
   tms570_memtest_start(PBIST_RINFOL_ESRAM1_RAM);
   DEBUGASSERT(tms570_memtest_complete() == OK);
   
   If DEBUGASSERT not enabled, we will never rendezvous with completion of the test.
   
   **(2) Later in the same function, line 382, arch/arm/src/tms570/tms570_boot.c:**
   
   DEBUGASSERT(tms570_memtest_complete() == OK);
   
   Same problem (?)
   
   **(3) In function tms570_clockconfig(), line 842, arch/arm/src/tms570/tms570_clockconfig.c:**
   
   DEBUGASSERT(tms570_efc_selftest_complete() == 0);
   
   Same problem (?)
   
   **(4) In function board_late_initialize(), line 92, boards/arm/sam34/sam4s-xplained-pro/src/sam_boot.c:**
   
   DEBUGASSERT(sam_watchdog_initialize() >= 0);
   
   Watchdog would not be initialized if DEBUGASSERT is not enabled.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message