nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #764: Minor netlink fix
Date Fri, 10 Apr 2020 16:42:16 GMT
xiaoxiang781216 commented on issue #764: Minor netlink fix
URL: https://github.com/apache/incubator-nuttx/pull/764#issuecomment-612113899
 
 
   > I lot of this is good code clean-up. And there is some that I don't fully understand.
I trust that you have verified operation of the netlink sockets. There is a test for NETLINK_ROUTE
at apps/examples/netlink_route.
   > 
   
   Yes, I run netlink_route test and the new -t option for arp
   
   > The removal of netlink_notify_response() concerns me most. This was cause the caller
to block until the response to the netlink command is received. I think that they issue that
you are addressing is that this is used in netlink_poll() which should not block. Is that
correct?
   
   Yes, netlink_poll already setup monitor by calling netlink_notifier_setup and should return
to caller directly,  the caller will block on the pontential multiple sem for us.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message