nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #761: Merge garbage feature to mm/mm_heap
Date Thu, 09 Apr 2020 16:50:03 GMT
xiaoxiang781216 commented on a change in pull request #761: Merge garbage feature to mm/mm_heap
URL: https://github.com/apache/incubator-nuttx/pull/761#discussion_r406338370
 
 

 ##########
 File path: include/nuttx/mm/mm.h
 ##########
 @@ -263,6 +270,12 @@ struct mm_heap_s
    */
 
   struct mm_freenode_s mm_nodelist[MM_NNODES];
+
+#ifdef __KERNEL__
+  /* Free delay list, for some situation can't do free immdiately */
+
+  struct mm_delaynode_s mm_delaylist;
 
 Review comment:
   Ok, let wait Guiding provide a minor fix tomorrow.
   
   > A better, more consistent name would probably be mm_delayhead to indicate that it
is a head of a list. sq_queue_t could be used, but that is not really necessary.
   
   Guiding intentionally avoid to use sq_queue_t  just because the whole mm code base don't
use sq_queue_t/dq_queue_t manage the list, he don't want to introduce the additional dependence.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message