nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx
Date Wed, 08 Apr 2020 20:40:18 GMT
hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-611182808
 
 
   I'd like to mark this PR as "Do Not Merge" for now. I'm working on addressing this but
it will be a few days.
   
   > On Apr 8, 2020, at 2:51 PM, David Sidrane <notifications@github.com> wrote:
   > 
   > 
   > @davids5 requested changes on this pull request.
   > 
   > @hartmannathan See inline
   > 
   > In arch/arm/include/stm32h7/chip.h:
   > 
   > > @@ -53,16 +53,40 @@
   >   *
   >   *   PART        PACKAGE
   >   *   ----------- ----------------
   > + *   STM32H7x3Ax UFBGA169
   > @hartmannathan
   > 
   > Where is that addressed?
   > 
   > Grep for STM32H7_NGPIO then look at the F7 and follow the pattern.
   > 
   > For the package with different pin counts we do not want to make something that is
not whole appear to be. Or said another way: A problem found at compile time is much better
then one found in the debugger.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message