nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] acassis commented on a change in pull request #719: Kinetis lpc sdcard
Date Sat, 04 Apr 2020 01:35:41 GMT
acassis commented on a change in pull request #719: Kinetis lpc sdcard
URL: https://github.com/apache/incubator-nuttx/pull/719#discussion_r403405996
 
 

 ##########
 File path: arch/arm/src/lpc17xx_40xx/lpc17_40_sdcard.c
 ##########
 @@ -317,7 +322,8 @@ static inline uint32_t lpc17_40_getpwrctrl(void);
 static void lpc17_40_sampleinit(void);
 static void lpc17_40_sdcard_sample(struct lpc17_40_sdcard_regs_s *regs);
 static void lpc17_40_sample(struct lpc17_40_dev_s *priv, int index);
-static void lpc17_40_sdcard_dump(struct lpc17_40_sdcard_regs_s *regs, const char *msg);
+static void lpc17_40_sdcard_dump(struct lpc17_40_sdcard_regs_s *regs,
+                                 const char *msg);
 
 Review comment:
   Hmm, I missed the column start position, normally I use as reference the "(" in the previous
line. But some cases like ABIGMACRONAMEA | ABIGMACRONAMEB I try to keep it aligned the beginning
of the first macro name. I will fix it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message