nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
Date Fri, 03 Apr 2020 13:56:32 GMT
xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout
and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403023220
 
 

 ##########
 File path: netutils/dhcpc/dhcpc.c
 ##########
 @@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
 
       /* Configure for read timeouts */
 
-      tv.tv_sec  = 10;
+      tv.tv_sec  = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
 
 Review comment:
   10sec for the timeout is too large for the most nowaday network, especially for DHCP transaction
which always happen between two nodes directly without any intermediate node.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message