nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] acassis commented on issue #699: Check return of nxsem_wait_uninterruptible
Date Fri, 03 Apr 2020 11:28:07 GMT
acassis commented on issue #699: Check return of nxsem_wait_uninterruptible
URL: https://github.com/apache/incubator-nuttx/pull/699#issuecomment-608382173
 
 
   > > As a best practice I think that we should always submit nxstyle fixes and the
actual patch in a PR
   > > This will make our life easier when we review the code
   > 
   > Yes, the actual patch PR can't pass the precheck if nxstyle is on another PR. But
it's better to split the nxstyle change into another patch, so the reviewer can focus on the
real change.
   
   Yes, it is failing because long lines:
   
   fda56a8afd Check return of nxsem_wait_uninterruptible
   ../nuttx/tools/checkpatch.sh -g fda56a8afd209ca98a1e91e455c84a7992f27e50
   arch/arm/src/lc823450/lc823450_i2s.c:200:80: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:202:84: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:206:80: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:208:81: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:331:79: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:413:80: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:438:87: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:499:79: error: Long line found
   arch/arm/src/lc823450/lc823450_i2s.c:514:1: error: Too many blank lines
   arch/arm/src/lc823450/lc823450_i2s.c:586:79: error: Long line found
   ##[error]Process completed with exit code 1.
   
   Also the CI is very unstable currently, many errors like this:
   
   Unable to find image 'docker.pkg.github.com/apache/incubator-nuttx-testing/nuttx-ci-linux:latest'
locally
   /usr/bin/docker: Error response from daemon: received unexpected HTTP status: 504 Gateway
Time-out.
   
   Maybe it is the COVID-19 side-effect!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message