nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #699: Check return of nxsem_wait_uninterruptible
Date Fri, 03 Apr 2020 11:22:21 GMT
xiaoxiang781216 commented on issue #699: Check return of nxsem_wait_uninterruptible
   > > > > Hi @acassis,
   > > > > Please fix the build break first and force to push this PR again.
   > > > > You can use lc823450-xgevk:audio configuration to check.
   > > > 
   > > > 
   > > > Hi @masayuki2009 the style changing were necessary because nxstyle was reporting
error. The original lines had more than 78 chars by line. We used to break lines only when
it hit 80 chars, but now without these modifications it will not pass on CI validation. I
will create a single patch all modifications.
   > > 
   > > 
   > > I think what @masayuki2009 suggesion is split the patch into two:
   > > 1.The first one fix the real problem
   > > 2.The second one fix nxstyle issue
   > > but these two patch sent in one PR.
   > > So we can review the real change more carefully.
   > Ok, I can do it, but I suppose it could fail because nxstyle issues in the file.
   No, the precheck will pull all patch in PR before starting. so the nxstyle and build is
against the final source code.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message