nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
Date Wed, 01 Apr 2020 14:31:33 GMT
xiaoxiang781216 commented on a change in pull request #23: Add macOS builds
URL: https://github.com/apache/incubator-nuttx-testing/pull/23#discussion_r401660326
 
 

 ##########
 File path: cibuild.sh
 ##########
 @@ -37,20 +47,39 @@ function python-tools {
   add_path $PYTHONUSERBASE/bin
 }
 
+function flock {
+  case $os in
+    Darwin)
+      brew tap discoteq/discoteq
 
 Review comment:
   Why not if the change can simplify the script? macOS will be pure subset of Linux if we
take this approach for genromfs and flock and HOMEBREW_CACHE also don't need anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message