nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] yamt commented on a change in pull request #681: Dns the dual stack support(part 2)
Date Wed, 01 Apr 2020 11:53:01 GMT
yamt commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401556825
 
 

 ##########
 File path: libs/libc/netdb/lib_gethostbyaddrr.c
 ##########
 @@ -61,8 +60,10 @@
 
 struct hostent_info_s
 {
+  int       hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+  int       hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
 
 Review comment:
   is "+ 1" necessary?
   hi_addrlist needs +1 for terminating NULL. i guess these two don't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message