nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] yamt commented on a change in pull request #677: testbuild.sh: Add an option to show the list of configs
Date Wed, 01 Apr 2020 05:20:36 GMT
yamt commented on a change in pull request #677: testbuild.sh: Add an option to show the list
of configs
URL: https://github.com/apache/incubator-nuttx/pull/677#discussion_r401361619
 
 

 ##########
 File path: tools/testbuild.sh
 ##########
 @@ -196,12 +201,21 @@ function build {
 # Coordinate the steps for the next build test
 
 function dotest {
-  echo "===================================================================================="
+  if [ ${PRINTLISTONLY} -ne 1 ]; then
 
 Review comment:
   do you mean something like this?
   
       function print_separator {
         if [ ${PRINTLISTONLY} -ne 1 ]; then
             echo "===================================================================================="
         fi
       }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message