From commits-return-4146-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat Mar 7 19:23:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 022C918025F for ; Sat, 7 Mar 2020 20:23:35 +0100 (CET) Received: (qmail 76349 invoked by uid 500); 7 Mar 2020 19:23:35 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 76340 invoked by uid 99); 7 Mar 2020 19:23:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2020 19:23:35 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] patacongo commented on issue #478: nxglib: Remove warning "Assuming 24-bit color is not packed" Message-ID: <158360901527.20532.12012358612060092638.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 07 Mar 2020 19:23:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo commented on issue #478: nxglib: Remove warning "Assuming 24-bit color is not packed" URL: https://github.com/apache/incubator-nuttx/pull/478#issuecomment-596129291 There is an issue with the graphics/nxglib/nxglib_fillrun.h header file. It is not really a header file. It is a "template" of a C file that is included with some definitions to make a complete C file. So it will NOT pass the tests for a header file. It is not clear how this case should be handled. I believe we either have change the file name extension (but then it won't be checked at all) or change the extension to .c (which is misleading too). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services