nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo opened a new pull request #602: Remove support for CONFIG_FS_WRITABLE
Date Sat, 21 Mar 2020 20:19:41 GMT
patacongo opened a new pull request #602: Remove support for CONFIG_FS_WRITABLE
URL: https://github.com/apache/incubator-nuttx/pull/602
 
 
   And also CONFIG_FS_READABLE.
   
   This resolves issue #484 and is a companion to the PR 131 in incubator_nuttx_apps.  Per
Issue 484:
   
   This is kind of a useless configuration variable that occurs in many places and adds a
lot of complexity and makes debug a lot more difficult.
   
   It makes debug more difficult because it is not consistently set and requires a lot of
debug time before you finally figure out "I need to set CONFIG_FS_WRITABLE.
   
   In most places affected by CONFIG_FS_WRITABLE, the configuration option is stupid: Who
needs read-only MMC or read-only SmartFS. Just not a useful thing. And many places that do
need CONFIG_FS_WRITABLE do not automatically set it. Like drivers/mtd/ftl.c. In that case,
you can debug for most of the day before you finally figure out why the you can't access flash
via character driver (which is a really common configuration for resource limited platforms).
   
   It is hard to imagine a platform that supports a file system but has no writing enabled.
I could imagine a system with only ROMFS or only CROMFS. But that is really about it and,
in those cased, CONFIG_FS_WRITABLE has no effect. I am not aware of any such case, but that
would be the only kind of platform that would suffer from the change.
   
   But my opinion is that in the bigger picture, NuttX would be cleaner, less complex, and
more usable with CONFIG_FS_WRITABLE removed.
   
   CONFIG_FS_REABABLE was also becaue it does nothing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message