nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] davids5 opened a new pull request #562: Revert stm32f7:stm32_flash.c: Add flash block mapping support for progmem
Date Fri, 13 Mar 2020 14:29:40 GMT
davids5 opened a new pull request #562: Revert stm32f7:stm32_flash.c: Add flash block mapping
support for progmem
URL: https://github.com/apache/incubator-nuttx/pull/562
 
 
   This reverts commit 29164c5706490b74a84d44ba0f79cd588fd3e910.
   
   As mentioned [here](https://github.com/apache/incubator-nuttx/pull/391#issuecomment-596083672)
   
   29164c5 breaks the API as defined in include/nuttx/progmem.h. It should not have come in
to upstream. 
   
   While it may seem that a the difference between pages, blocks and sectors are semantic
arguments it is not. Code relying on the sector size, to program a sectors of different sizes
was broken by this commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message