nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From masay...@apache.org
Subject [incubator-nuttx-apps] 01/03: Makefile: remove context dependency to avoid apps context build twice
Date Thu, 19 Mar 2020 23:30:27 GMT
This is an automated email from the ASF dual-hosted git repository.

masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git

commit 06c9f9359ef7949cd36eeb9b5c6ba53cd5abbfe6
Author: liuhaitao <liuhaitao@xiaomi.com>
AuthorDate: Wed Mar 18 20:30:50 2020 +0800

    Makefile: remove context dependency to avoid apps context build twice
    
    In nuttx pass1dep and pass2dep builds, context firstly would be built once.
    It then call 'make -C apps depend' which would trigger the context built twice.
    There is race condition between symtab.c generated by mksymtab.sh in second time
    and compiling symtab.c in parallel build. So remove context dependency for apps
    depend to make sure context build only one time for apps.
    
    Parallel build break logs as below:
    /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357:
undefined reference to `g_elf_nexports'
    riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357:
undefined reference to `g_elf_exports'
    make[1]: *** [nuttx] Error 1
    make: *** [pass2] Error 2
    
    Change-Id: I2872f7036e7ec86615efc5ebd7c46cee51dc1094
    Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 6744ef7..5956c64 100644
--- a/Makefile
+++ b/Makefile
@@ -167,7 +167,7 @@ endif
 
 .depdirs: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_depend)
 
-.depend: context Makefile .depdirs
+.depend: Makefile .depdirs
 	$(Q) touch $@
 
 depend: .depend


Mime
View raw message