nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #637: NRF52: protect the I2C transfer with a semaphore and fix some coding standard issues
Date Fri, 27 Mar 2020 18:09:33 GMT
raiden00pl commented on a change in pull request #637: NRF52: protect the I2C transfer with
a semaphore and fix some coding standard issues
URL: https://github.com/apache/incubator-nuttx/pull/637#discussion_r399451678
 
 

 ##########
 File path: arch/arm/src/nrf52/nrf52_i2c.c
 ##########
 @@ -223,6 +223,8 @@ static int nrf52_i2c_transfer(FAR struct i2c_master_s *dev,
   uint32_t regval = 0;
   int      ret = OK;
 
+  nxsem_wait_uninterruptible(&priv->sem_excl);
+
 
 Review comment:
   Yes, you are right. I just made a copy-paste from stm32 which I see is also affected by
this issue. Corrected as you recomended.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message