nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c: When no make argument is passed, silence make output.
Date Mon, 23 Mar 2020 19:34:43 GMT
xiaoxiang781216 commented on a change in pull request #615: tools/sethost.sh & tools/configure.c:
When no make argument is passed, silence make output.
URL: https://github.com/apache/incubator-nuttx/pull/615#discussion_r396706158
 
 

 ##########
 File path: tools/configure.c
 ##########
 @@ -382,10 +382,18 @@ static int run_make(const char *arg)
   char **argv;
 
   snprintf(g_buffer, BUFFER_SIZE, "make %s", arg);
-  for (argv = g_makeargv; *argv; argv++)
+
+  if (!*g_makeargv)
+    {
+      strncat(g_buffer, " 1>/dev/null", BUFFER_SIZE - 1);
 
 Review comment:
   Window native don't have /dev/null, need do something like the previous code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message