nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #136: Let install depend on the target binary
Date Sun, 22 Mar 2020 20:52:41 GMT
patacongo commented on a change in pull request #136: Let install depend on the target binary
URL: https://github.com/apache/incubator-nuttx-apps/pull/136#discussion_r396138947
 
 

 ##########
 File path: Application.mk
 ##########
 @@ -151,6 +151,7 @@ PROGLIST := $(addprefix $(BINDIR)$(DELIM),$(PROGLIST))
 PROGOBJ := $(MAINOBJ)
 
 $(PROGLIST): $(MAINOBJ)
+	$(Q) mkdir -p $(BINDIR)
 
 Review comment:
   Certainly this is a big risk because I don't see any reference to mkdir in any other Make*
or *.mk file.  We need to be careful here.
   
   
   Hmm.. something wrong with my grep:
   
       Makefile.unix:  $(Q) mkdir -p staging
       Makefile.win:   $(Q) mkdir -p staging
   
   Maybe there is no issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message