nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #136: Let install depend on the target binary
Date Sun, 22 Mar 2020 20:52:40 GMT
patacongo commented on a change in pull request #136: Let install depend on the target binary
URL: https://github.com/apache/incubator-nuttx-apps/pull/136#discussion_r396137838
 
 

 ##########
 File path: Application.mk
 ##########
 @@ -151,6 +151,7 @@ PROGLIST := $(addprefix $(BINDIR)$(DELIM),$(PROGLIST))
 PROGOBJ := $(MAINOBJ)
 
 $(PROGLIST): $(MAINOBJ)
+	$(Q) mkdir -p $(BINDIR)
 
 Review comment:
   1) mkdir should not be used explicitly.  This is incompatible with Window native builds.
 You should define something.
   2) If my recollection is correct, mkdir -p does not work on some Unix platforms, I think
macOS.
   
   Update:  I am probably wrong about the incompatibilities.  Tht would requrire some additional
investigation to be certain of the compatibiltiey issues.  Still usage of explict mkdir is
not a good style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message