nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #581: SocketCAN initial beta
Date Tue, 17 Mar 2020 18:56:47 GMT
patacongo commented on a change in pull request #581: SocketCAN initial beta
URL: https://github.com/apache/incubator-nuttx/pull/581#discussion_r393902266
 
 

 ##########
 File path: include/nuttx/can/error.h
 ##########
 @@ -0,0 +1,127 @@
+/* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */
 
 Review comment:
   > So this header is borrowed from Linux and created by Oliver Hartkopp and is BSD or
GPL licensed. @patacongo for the initial commits in this SocketCAN you've also reused some
code Linux, the question what's the correct to change this header to NuttX code format and
Apache license yet still reference to the original BSD licensed material?
   
   That is beyond my knowledge of the intricacies of licensing.  @justinmclean should have
some input.  We did discuss this strange dual license. It is from the original VW SocketCAN
code.  At that time, the advice was this this should not be an obstacle.
   
   I don't think we should change anything until we have a good understanding.  I believe
that we can merge the code onto a branch and make sure that we have what even license headers,
ICLAs, or software grants in place before we merge to master.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message