nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #121: apps/system/cle: Fix error when compiling with C89 compiler.
Date Sat, 14 Mar 2020 20:24:19 GMT
patacongo commented on a change in pull request #121: apps/system/cle:  Fix error when compiling
with C89 compiler.
URL: https://github.com/apache/incubator-nuttx-apps/pull/121#discussion_r392616489
 
 

 ##########
 File path: system/cle/cle.c
 ##########
 @@ -798,6 +799,9 @@ static int cle_editloop(FAR struct cle_s *priv)
 
   for (; ; )
     {
+#if  1 /* Perhaps here should be a config switch */
 
 Review comment:
   It was NOT added.  It was already there.  Just copied from its original location.  The
original author intended to add a configuration option but left #if1 in place of the missing
option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message