nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #567: nxstyle: Added assembly header detection.
Date Sat, 14 Mar 2020 14:23:20 GMT
patacongo commented on issue #567: nxstyle: Added assembly header detection.
URL: https://github.com/apache/incubator-nuttx/pull/567#issuecomment-599068377
 
 
   > I'm not sure if continue fixing nxstyle issues makes sense during the undergoing efforts
to switch to clang-format or comparable.
   
   It will be weeks or perhaps even months before we know the answer to that.  I don't know
that is a good idea to run all files wholesale through a pretty printer.  I would have to
have extreme confidence in the tool to be really enthusiatic about that.  Such a tool will
need some significant mileage before we can be certain.
   
   But such a tool could potencially simplify a lot if it were truy trustworthy.  So let's
wait and see.  You have experience some of the complex cornercases in the code, the tool has
not yet.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message