nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c: Fix wrong fopen() mode.
Date Fri, 13 Mar 2020 23:21:20 GMT
patacongo commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c: Fix
wrong fopen() mode.
URL: https://github.com/apache/incubator-nuttx/pull/558#discussion_r392524223
 
 

 ##########
 File path: libs/libc/netdb/lib_dnsaddserver.c
 ##########
 @@ -87,7 +87,7 @@ int dns_add_nameserver(FAR const struct sockaddr *addr, socklen_t addrlen)
   int status;
   int ret;
 
-  stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "at");
+  stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "r");
 
 Review comment:
   > But if you read the whole function carefully, you can find dns_add_nameserver don't
has any other real action if the file can't write.
   
   From the little reading I have done, that does not seem exactly the case:
   
   - If DHCPC is used the, yes, /etc/resolve/conf may be updated (via resolvconf).  In this
case, resolv.conf would need to be on writable media.  But updates to resovle.conf from DHCPC
is not supported by our implementation of DHCPC.
   - On static IP configurations without DHCPC, resolve.conf is not modified by the system,
and hence would be effectly read-only.
   
   Or am I reading that wrong.
   
   If the above is correct, then at the present time the argument should be "r" but would
have to be revisited if the capability of DHCPC were improved.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message