nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c: Fix wrong fopen() mode.
Date Fri, 13 Mar 2020 14:51:19 GMT
xiaoxiang781216 commented on a change in pull request #558: libs/libc/netdb/lib_dnsaddserver.c:
Fix wrong fopen() mode.
URL: https://github.com/apache/incubator-nuttx/pull/558#discussion_r392276007
 
 

 ##########
 File path: libs/libc/netdb/lib_dnsaddserver.c
 ##########
 @@ -87,7 +87,7 @@ int dns_add_nameserver(FAR const struct sockaddr *addr, socklen_t addrlen)
   int status;
   int ret;
 
-  stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "at");
+  stream = fopen(CONFIG_NETDB_RESOLVCONF_PATH, "r");
 
 Review comment:
   > Perhaps there should be an option to support a read-only /etc/resolv.conf?
   
   But if you read the whole function carefully, you can find dns_add_nameserver don't has
any other real action if the file can't write.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message