nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
Date Wed, 11 Mar 2020 14:57:30 GMT
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597682980
 
 
   Wow... 180 seems excessive.  We need to get you out of the critical path on this one so
that you can move forward and have a good life.
   
   But I can't help be believe that there are not just a few lines that are forcing that huge
"ruler", just breaking up a few lines probably all that is necessary.  But let's not burden
you with that.
   
   Many people have a habit of trying to say too much in register definition files.  I am
guilty of that at times too.  It is easier to copy-paste a long bit description from a specificiation
than it is to re-write a concise short description.  The intention of the register definitions
files is simply to provide a proper definition.  The comment should not explain the detailed
properties of the bit; the user should look in the reference manual for that.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message