nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #525: nxstyle: Does not check for braces.
Date Tue, 10 Mar 2020 17:30:38 GMT
patacongo commented on issue #525: nxstyle:  Does not check for braces.
URL: https://github.com/apache/incubator-nuttx/issues/525#issuecomment-597214875
 
 
   @johannes-nivus It is important that we document shortcomings in nxstyle, whether we fix
them or not.  In order to implement this particular feature, some minimal syntax parsing would
be required; I am not sure we want to go that route.  But we definitely need an issue in place
to remind us that not all coding standard issues are addresses.
   
   There are many, many things that are not checked by nxstyle.  Some that come to mind:
   
   Non-local scope (global) varialbes must begin with g_
   Structure names must end with _s, union names must end with _u, enumeration names must
end with _e, typedef'e names must end with _t
   All identifiers are local case except the pre-processor names are all upper case.
   etc.
   
   There are more coding standard issues that are NOT addressed than there are coding standard
issues addresses.  I am not familiar with any automated pretty printer than can fix such things
either.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message