nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
Date Tue, 10 Mar 2020 16:53:24 GMT
xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597195078
 
 
   > I see, nxstyle.c has changed in the meanwhile.
   > I fixed everything he says now, except this:
   > 
   > arch/arm/src/stm32h7/Kconfig: info: No file extension
   > arch/arm/src/stm32h7/Kconfig: info: Unknown file extension
   > 
   > I hope this will not stop the automatic checks to pass.
   >
   
   This is just an information, don't stop precheck. Actually, a PR already remove this info:
   https://github.com/apache/incubator-nuttx/pull/526
    
   > P.S. Sidenote: in tools/checkpatch.h you could get the list of files in a commit much
simpler:
   > git show --name-only --pretty="" [94a73a8](https://github.com/apache/incubator-nuttx/commit/94a73a87363557b839b8c1bc032f7c77d02e5044)
   > or even
   > git show --name-only --pretty="" [94a73a8](https://github.com/apache/incubator-nuttx/commit/94a73a87363557b839b8c1bc032f7c77d02e5044)..HEAD
   
   Yes, but checkpatch.sh support to just check the lines you really modify not the whole
file. You can try something like this:
   checkpatch.sh -r -g HEAD
   And compare it with:
   checkpatch.sh -g HEAD
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message