nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial
Date Tue, 10 Mar 2020 14:34:41 GMT
xiaoxiang781216 edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597118689
 
 
   > > "If you want things done right, do it yourself."
   > 
   > You could, for example, bring the changes onto a branch, revert only the rcc.h file,
amend the PR, and merge what is left to master. Up to you.
   
   I agree that committer could help contributor make the style change, but contributor shouldn't
directly merge the change to mainline, the new PR still need go through the precheck/build
process again. committer is human and human will make mistake, only tool can ensure there
isn't error happen in this type of modification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message