nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] davids5 commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
Date Tue, 10 Mar 2020 12:29:10 GMT
davids5 commented on a change in pull request #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#discussion_r390278568
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_allocateheap.c
 ##########
 @@ -246,6 +249,14 @@ void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
 
   up_heap_color(*heap_start, *heap_size);
 #endif
+
+#if defined(CONFIG_DEBUG_FEATURES)
+
+  /* Display memory ranges to help debugging */
+
+  _info("%uKb of SRAM at %p\n", *heap_size / 1024, *heap_start);
 
 Review comment:
   So the `correct and best` thing to do is to look and see if the HW has an SDRAM in it.
Then add a config and update board.h for thoses ones.  It if does not then there is no action
needed.
   
   The issue is that, if you do not have the HW you can not verify it. But you are the `expert`
on this at this point in time and can share that expertise in a board config so that when
some does try to use it, they are closer to making it work that staring from scratch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message