nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #496: Nxstyle
Date Mon, 09 Mar 2020 20:54:32 GMT
patacongo commented on issue #496: Nxstyle
URL: https://github.com/apache/incubator-nuttx/pull/496#issuecomment-596774228
 
 
   One changed behavior I am seeing is for example with this code snippet:
   
                case RECORD_EXT_SEGADDR: /* Extended segment address record */
                  /* The address specified by the data field is multiplied by 16
                   * (shifted 4 bits left) and added to the subsequent data record
                   * addresses. This allows addressing of up to a megabyte of
   
   nxstyle in the past would have claimed that I need a blank line before the (second) comment.
 Now it complains that the second "right hand" comment is not aligned properly.  Both are
correct complaints, but the old one was  more interpretable.  Both are fixed in the same way...
by adding the blank like before the comment.
   
                case RECORD_EXT_SEGADDR: /* Extended segment address record */
       +
                  /* The address specified by the data field is multiplied by 16
                   * (shifted 4 bits left) and added to the subsequent data record
                   * addresses. This allows addressing of up to a megabyte of
   
   I don't think that there is a problem here, just a change in behavior.
   
   BTW:  I think you did a great job!  Feel free to add additional functionality to nxstyle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message