nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #120: tools/nxstyle.c: FALSE alarms on right hand aligned comments.
Date Sun, 08 Mar 2020 19:47:07 GMT
patacongo commented on issue #120: tools/nxstyle.c:  FALSE alarms on right hand aligned comments.
URL: https://github.com/apache/incubator-nuttx/issues/120#issuecomment-596244281
 
 
   The tests that should be performed are:
   
   1. Using a test case, verify that positirves are detected.
   
   2. Check for false negatives/positive regression.  I do that with a little script something
like:
   
       #!/bin/sh
       
       FILELIST=`find sched -name *.c`
       for file in $FILELIST; do
           tools/nxstyle $file
       done
   
   Then run that before the change like:
   
       ./doit.sh 1>before.txt 2>&1
   
   Then rebuild with the modified nxstyle.c and:
   
       ../doit.sh 1>after.txt 2>&1
   
   Then compare before.txt with after .txt.  They should be identical or, if there are false
positives/negatives in before.txt, then after.txt might have fixed those.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message