nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #471: Changes for Freedom K28 USB device support
Date Sun, 08 Mar 2020 03:43:05 GMT
xiaoxiang781216 commented on issue #471: Changes for Freedom K28 USB device support
URL: https://github.com/apache/incubator-nuttx/pull/471#issuecomment-596163161
 
 
   > @xiaoxiang781216
   > 
   > > I can't understand why another repo can resolve nxstyle update issue.
   > 
   > Assume The tool in master of nuttx is changing.
   > 
   > What workflow can you use to get the latest version of the tool?
   > 
   > 1. Reabse your work on master before submission. - With the instability in master
this is risky.
   
   Why I can't do this?
   git branch --track upstream origin/master
   git checkout upstream
   git cherry-pick mywork
   ./toos/checkpatch.sh -c upstream
   git push ....
   
   since the big work always done in a feature branch, I don't think there is any risky to
rebase the feature branch against master.
   
   >    Your good work WILL be impeded by the lack of QA on master.
   
   Actually, contributor must rebase/cherry-pick his patch against master before send PR.
   
   > 2. stash your work, fetch and build nxstyle from master at HEAD. Copy it do /usr/local/bin
   >    stash pop and run the tool.
   > 3. Have a submodule with the tools in it.
   >    cd tools;git fetch nuttx-tools;git reset hard nuttx-tools/master;cd ..
   >    Work as normal.
   
   But I need remember update/compile/copy another repo every time:(.
   
   > 
   > Then CI only uses nuttx-tools
   
   As you said nutx-tools just for CI, it's hard to tell people to clone this repo. I still
think the nuttx/tools is a better place to put the tool which can be used by developer machine
directly. nuttx-tools is for the script that need run on github/apache server.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message