Mailing-List: contact nutch-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: nutch-dev@lucene.apache.org
Message-ID: <19857466.1179086955634.JavaMail.jira@brutus>
Date: Sun, 13 May 2007 13:09:15 -0700 (PDT)
From: =?utf-8?Q?Do=C4=9Facan_G=C3=BCney_=28JIRA=29?= <jira@apache.org>
To: nutch-dev@lucene.apache.org
Subject: [jira] Commented: (NUTCH-485) Change HtmlParseFilter 's to return
 ParseResult object instead of Parse object
In-Reply-To: <4593739.1178999415286.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/NUTCH-485?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495410 ]=20

Do=C4=9Facan G=C3=BCney commented on NUTCH-485:
-------------------------------------

I have two more minor nits:

1) ParseResult.isSuccess returns true only if all parses are successful. Th=
is makes sense, but I think you should make it more obvious by mentioning i=
t in method's javadoc.=20

2) There seems to be some whitespace issues. For  example, some indents are=
 4 spaces. All indents should be 2 space-indents.

Anyway, I don't know if my vote counts, but, besides these two issues, I am=
 +1 on this patch.

I think this may be very useful for image search. After parsing a page, one=
 can traverse DOM, add image src's as urls and the immediate text around im=
ages as parse text (+ whatever data you can gather as parse data). Of cours=
e, this doesn't automatically make Nutch an image search engine, but is a g=
ood first step.

> Change HtmlParseFilter 's to return ParseResult object instead of Parse o=
bject
> -------------------------------------------------------------------------=
-----
>
>                 Key: NUTCH-485
>                 URL: https://issues.apache.org/jira/browse/NUTCH-485
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.0.0
>         Environment: All
>            Reporter: Gal Nitzan
>             Fix For: 1.0.0
>
>         Attachments: NUTCH-485.200705122151.patch, NUTCH-485.200705130928=
.patch, NUTCH-485.200705130945.patch, NUTCH-485.200705131241.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filte=
r to add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to retu=
rn ParseResult . and ofcourse a change to  HtmlParseFilters .

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.