nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doğacan Güney (JIRA) <j...@apache.org>
Subject [jira] Commented: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object
Date Sun, 13 May 2007 20:09:15 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495410
] 

Doğacan Güney commented on NUTCH-485:
-------------------------------------

I have two more minor nits:

1) ParseResult.isSuccess returns true only if all parses are successful. This makes sense,
but I think you should make it more obvious by mentioning it in method's javadoc. 

2) There seems to be some whitespace issues. For  example, some indents are 4 spaces. All
indents should be 2 space-indents.

Anyway, I don't know if my vote counts, but, besides these two issues, I am +1 on this patch.

I think this may be very useful for image search. After parsing a page, one can traverse DOM,
add image src's as urls and the immediate text around images as parse text (+ whatever data
you can gather as parse data). Of course, this doesn't automatically make Nutch an image search
engine, but is a good first step.

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> ------------------------------------------------------------------------------
>
>                 Key: NUTCH-485
>                 URL: https://issues.apache.org/jira/browse/NUTCH-485
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.0.0
>         Environment: All
>            Reporter: Gal Nitzan
>             Fix For: 1.0.0
>
>         Attachments: NUTCH-485.200705122151.patch, NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch,
NUTCH-485.200705131241.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to add parse
objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return ParseResult
. and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message