From issues-return-104250-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Oct 2 01:15:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id A674018064E for ; Fri, 2 Oct 2020 03:15:39 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id D9F511238A9 for ; Fri, 2 Oct 2020 01:15:38 +0000 (UTC) Received: (qmail 33628 invoked by uid 500); 2 Oct 2020 01:15:38 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 33619 invoked by uid 99); 2 Oct 2020 01:15:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Oct 2020 01:15:38 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_levilentz_commented_on_pull_request_=23420?= =?utf-8?q?4=3A_NIFI-7355_Added_Gremlin_bytecode_client_service=2E?= Message-ID: <160160133812.32230.5946427959528516341.asfpy@gitbox.apache.org> Date: Fri, 02 Oct 2020 01:15:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: levilentz commented on pull request #4204: URL: https://github.com/apache/nifi/pull/4204#issuecomment-702476413 > @levilentz can you take a look at this and get back to me on what improvements you made need to be incorporated? @MikeThomsen, the main changes that I have are the following: 1. Allow for custom Jar specification 2. Allow for custom Class import 3. Allow for specification of Yaml connection string or file 4. Logic to allow for more complex object returns from the groovy script (right now it only plays well with simple-ish objects) 1, 2, and 3 are really important for connecting to services such as Janusgraph that are "gremlin-compliant" but are more efficient when you use their encoders/decoders. 4 is a nice to have and might be outside the scope of this Ticket. Let me know what you think and if you want me to add that code into this branch. Thanks for all your work on this! This will be a really nice addition to the graph bundle. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org