From issues-return-104177-apmail-nifi-issues-archive=nifi.apache.org@nifi.apache.org Thu Oct 1 09:54:09 2020 Return-Path: X-Original-To: apmail-nifi-issues-archive@locus.apache.org Delivered-To: apmail-nifi-issues-archive@locus.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id 9FE951AC32 for ; Thu, 1 Oct 2020 09:54:09 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 9E06A63B0F for ; Thu, 1 Oct 2020 09:54:08 +0000 (UTC) Received: (qmail 29043 invoked by uid 500); 1 Oct 2020 09:54:08 -0000 Delivered-To: apmail-nifi-issues-archive@nifi.apache.org Received: (qmail 29006 invoked by uid 500); 1 Oct 2020 09:54:07 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 28996 invoked by uid 99); 1 Oct 2020 09:54:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2020 09:54:07 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_szaszm_commented_on_a_change_in?= =?utf-8?q?_pull_request_=23875=3A_MINIFICPP-1332_Prevent_errneous_behavior_?= =?utf-8?q?by_stopping_FlowController_in_low_disk_space_conditions?= Message-ID: <160154604774.32230.152953422665587626.asfpy@gitbox.apache.org> Date: Thu, 01 Oct 2020 09:54:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: szaszm commented on a change in pull request #875: URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498122682 ########## File path: libminifi/src/utils/file/PathUtils.cpp ########## @@ -84,13 +86,58 @@ std::string PathUtils::getFullPath(const std::string& path) { #endif } -std::string PathUtils::globToRegex(std::string glob) { +std::string globToRegex(std::string glob) { utils::StringUtils::replaceAll(glob, ".", "\\."); utils::StringUtils::replaceAll(glob, "*", ".*"); utils::StringUtils::replaceAll(glob, "?", "."); return glob; } +space_info space(const path p, std::error_code& ec) noexcept { Review comment: I'm not a fan of trailing underscores unless really necessary, so I went with `path` and let them clash. Let me know if you're fine with this approach. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org