nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #929: MINIFICPP-1397 Fix compilation errors when PCAP is enabled
Date Wed, 21 Oct 2020 12:59:12 GMT

fgerlits opened a new pull request #929:
URL: https://github.com/apache/nifi-minifi-cpp/pull/929


   The CapturePacket (PCAP) processor is not enabled by default, and it was not compiled in
any of our CI jobs, so it has got into a bad state where it no longer compiled.
   
   I have fixed this, although the integration test still failed after the fix.  I have disabled
the failing assertions in the integration test and enabled PCAP in one of the CI jobs.
   
   It will take more work to get this extension into a good state (and re-enable the assertions),
but until then it will not degrade further, at least.
   
   https://issues.apache.org/jira/browse/MINIFICPP-1397
   
   ---
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically
main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build
issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message