nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #914: MINIFICPP-1323 Encrypt sensitive properties using libsodium
Date Tue, 13 Oct 2020 15:16:08 GMT

fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r504036753



##########
File path: libminifi/include/properties/Properties.h
##########
@@ -65,7 +65,7 @@ class Properties {
    * @param value value in which to place the map's stored property value
    * @returns true if found, false otherwise.
    */
-  bool get(const std::string &key, std::string &value) const;
+  bool getString(const std::string &key, std::string &value) const;

Review comment:
       I think that by naming both functions in the parent and child classes `get()`, we would
be setting a trap for our future selves, and for anyone who will work on this code.  I agree
`getString()` is not a great name, but I would prefer to rename it to anything other than
`get()`.  How about `value()`, `getProperty()`, `getPropertyValue()` or something similar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message