From issues-return-103707-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Sep 22 10:17:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 5056818063F for ; Tue, 22 Sep 2020 12:17:02 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 7887F121EB9 for ; Tue, 22 Sep 2020 10:17:01 +0000 (UTC) Received: (qmail 25320 invoked by uid 500); 22 Sep 2020 10:17:01 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 25310 invoked by uid 99); 22 Sep 2020 10:17:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2020 10:17:01 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_fgerlits_commented_on_a_change_?= =?utf-8?q?in_pull_request_=23886=3A_MINIFICPP-1323_Encrypt_sensitive_proper?= =?utf-8?q?ties?= Message-ID: <160076982118.32230.592031501757068839.asfpy@gitbox.apache.org> Date: Tue, 22 Sep 2020 10:17:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: fgerlits commented on a change in pull request #886: URL: https://github.com/apache/nifi-minifi-cpp/pull/886#discussion_r492623813 ########## File path: encrypt-config/tests/CMakeLists.txt ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + + +file(GLOB ENCRYPT_CONFIG_TESTS "*.cpp") + +file(GLOB ENCRYPT_CONFIG_SOURCES "${CMAKE_SOURCE_DIR}/encrypt-config/*.cpp") Review comment: Can you suggest an alternative? I don't want to list each file, because then we would need to modify the CMakeLists.txt file every time we add a new .cpp file, which is easy to forget. Note that globs like this are used all over minifi. If we want to clear it up, I think we should do it in a separate pull request. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org