From issues-return-102633-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Thu Sep 3 07:49:14 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id DFCC6180636 for ; Thu, 3 Sep 2020 09:49:14 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 5F1BE62A13 for ; Thu, 3 Sep 2020 07:49:14 +0000 (UTC) Received: (qmail 5447 invoked by uid 500); 3 Sep 2020 07:49:13 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 5434 invoked by uid 99); 3 Sep 2020 07:49:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2020 07:49:13 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_simonbence_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=234420=3A_NIFI-7429_Adding_status_history_for_system_leve?= =?utf-8?q?l_metrics?= Message-ID: <159911935358.32230.16156492695971275331.asfpy@gitbox.apache.org> Date: Thu, 03 Sep 2020 07:49:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: simonbence commented on a change in pull request #4420: URL: https://github.com/apache/nifi/pull/4420#discussion_r482777095 ########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-status-history.js ########## @@ -78,6 +79,9 @@ }, 'DATA_SIZE': function (d) { return nfCommon.formatDataSize(d); + }, + 'FRACTION': function (d) { + return nfCommon.formatFloat(d / 1000000); Review comment: What I did find is the metrics functionality depends on long data type as metric data type, especially on Java side. Changing this looks as it would come with serious and possibly risky refactoring. Contrary, the processor load is usually in a range one or two digit number with fractions. I was playing with with some ideas, trying to avoid this method, but in the end they did not work well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org